Switch charting from react-native-charts-wrapper to @wuba/react-native-echarts#137
Draft
Switch charting from react-native-charts-wrapper to @wuba/react-native-echarts#137
Conversation
|
|
…ct-native-echarts Agent-Logs-Url: https://github.com/SpeedcuberOSS/speedcuber-timer/sessions/380158f3-0a81-4a8f-89d9-ef6a596685ee Co-authored-by: thehale <47901316+thehale@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consider switching to react-native-echarts for better performance
Switch charting from react-native-charts-wrapper to @wuba/react-native-echarts
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native-charts-wrapperwraps Android/iOS-specific native chart libraries and doesn't generalise to other platforms.@wuba/react-native-echartsbuilds on Apache ECharts using the already-presentreact-native-svg, giving better cross-platform portability and a richer chart API.Dependency changes
react-native-charts-wrapper+@types/react-native-charts-wrapper@wuba/react-native-echarts ^3.0.1,echarts ^5.4.3,zrender ^5.4.4transformIgnorePatternsexception listAttemptsChart
Replaces
CombinedChartwith EChartsscatter+lineseries rendered viaSvgChart. Visuals preserved: scatter of individual attempts, dashed yellow best-time line, configurable sliding-average lines.TPSChart
Replaces
LineChartwith EChartslineseries +areaStylelinear gradient. Smooth curve, gradient fill, and optional playback-position marker all preserved. Notably,atTimestampupdates on every playback frame — the two-effect pattern (init on layout,setOptionon data) avoids full chart recreation on each frame.Pattern used in both charts
Stale chart snapshots deleted; they will regenerate on next test run.